Add ParseCapacityString#10956
Merged
Merged
Conversation
briankassouf
approved these changes
Feb 20, 2021
Contributor
briankassouf
left a comment
briankassouf
left a comment
There was a problem hiding this comment.
One small comment, otherwise looks good!
| // gib, tb, tib, which are not case sensitive. If no prefix is present, the number is assumed | ||
| // to be in bytes already. | ||
| func ParseCapacityString(in interface{}) (uint64, error) { | ||
| var validCapacityString = regexp.MustCompile("^[\t ]*([0-9]+)[\t ]?([kmgtKMGT][iI]?[bB])?[\t ]*$") |
Contributor
There was a problem hiding this comment.
Can we move the regex to a package var so we don't have to recompile on each call?
raskchanky
force-pushed
the
logshipper-oss
branch
from
59cd3e9 to
315f868
Compare
ncabatoff
approved these changes
Feb 22, 2021
tsaarni
pushed a commit
to Nordix/vault
that referenced
this pull request
Jan 8, 2026
…) (hashicorp#10956) Co-authored-by: Vault Automation <github-team-secure-vault-core@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the OSS component of https://github.com/hashicorp/vault-enterprise/pull/1691