Fix: Transit encrypt batch does not honor key_version#11628
Merged
Conversation
…onor key_version
sgmiller
pushed a commit
that referenced
this pull request
May 27, 2021
* fix(secret/transit): #10232 Transit encrypt batch does not honor key_version * add changelog for 11628
sgmiller
pushed a commit
that referenced
this pull request
May 27, 2021
* fix(secret/transit): #10232 Transit encrypt batch does not honor key_version * add changelog for 11628
sgmiller
added a commit
that referenced
this pull request
Jun 1, 2021
sgmiller
added a commit
that referenced
this pull request
Jun 2, 2021
* Fix: Transit encrypt batch does not honor key_version (#11628) * fix(secret/transit): #10232 Transit encrypt batch does not honor key_version * add changelog for 11628 * Try a 5s request timeout * Pin aerospike container image to a known working tag. (#11677) Co-authored-by: rerorero <nato9598@hotmail.co.jp> Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10232
This PR fixes the bug where batch encrypt API doesn't work with
key_version( #10232).Because HTTP server parses a JSON body as a
map[string]interfacewith UseNumber(), logica.Request.Data can include json.Number instead of a primitive number.This PR fixes the issue by allowing additional json.Number in path_encrypt. I didn't use such as FieldSchema out of respect for this work: #8775
I checked the following queries worked