PostgreSQL logical backend#15
Merged
Merged
Conversation
Contributor
|
This is beautiful, nice work. |
Contributor
|
👍 |
jeffwecan
added a commit
to jeffwecan/vault
that referenced
this pull request
Nov 7, 2018
[NOJIRA] "terraform fmt" All The Things
briankassouf
pushed a commit
that referenced
this pull request
Aug 24, 2020
Trail of bits 018 (#9674)
swenson
pushed a commit
that referenced
this pull request
Apr 25, 2022
We don't support proper prepared statements, i.e., preparing once and executing many times since we do our own templating. So preparing our queries does not really accomplish anything, and can have severe performance impacts (see hashicorp/vault-plugin-database-snowflake#13 for example). This behavior seems to have been copy-pasted for many years but not for any particular reason that we have been able to find. First use was in #15 So here we switch to new methods suffixed with `Direct` to indicate that they don't `Prepare` before running `Exec`, and switch everything here to use those. We maintain the older methods with the existing behavior (with `Prepare`) for backwards compatibility.
swenson
added a commit
that referenced
this pull request
Apr 26, 2022
VAULT-5827 Don't prepare SQL queries before executing them We don't support proper prepared statements, i.e., preparing once and executing many times since we do our own templating. So preparing our queries does not really accomplish anything, and can have severe performance impacts (see hashicorp/vault-plugin-database-snowflake#13 for example). This behavior seems to have been copy-pasted for many years but not for any particular reason that we have been able to find. First use was in #15 So here we switch to new methods suffixed with `Direct` to indicate that they don't `Prepare` before running `Exec`, and switch everything here to use those. We maintain the older methods with the existing behavior (with `Prepare`) for backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a logical backend to dynamically generate SQL credentials for PostgreSQL. It is probably pretty easy the way I made it to generalize it to any SQL, but we're going to focus on PG first.
I'm going to add a few more features before merging.