Skip to content

Add known issue for hsm duplicate#28983

Merged
brewgator merged 13 commits into
mainfrom
known-issue-hsm-dupes
Nov 25, 2024
Merged

Add known issue for hsm duplicate#28983
brewgator merged 13 commits into
mainfrom
known-issue-hsm-dupes

Conversation

@brewgator
Copy link
Copy Markdown
Contributor

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@brewgator brewgator requested a review from a team as a code owner November 21, 2024 18:19
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 21, 2024
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

Comment thread website/content/partials/known-issues/duplicate-hsm-key.mdx
Luis (LT) Carbonell added 2 commits November 21, 2024 13:42
Luis (LT) Carbonell added 2 commits November 21, 2024 14:57
Copy link
Copy Markdown
Collaborator

@JMGoldsmith JMGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brewgator brewgator merged commit d23892d into main Nov 25, 2024
@brewgator brewgator deleted the known-issue-hsm-dupes branch November 25, 2024 14:57
Monkeychip pushed a commit that referenced this pull request Nov 27, 2024
* Add known issue for hsm duplicate

* update wording

* swap:

* more clarification

* clean up

* clean up

* clean up

* reorder

* reorder

* link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants