Skip to content

Backport of Fix Static Role Name Consistency in PostgreSQL Configuration into release/1.18.x#29366

Merged
jonathanfrappier merged 1 commit into
release/1.18.xfrom
backport/Correct-static-role-name/mistakenly-noted-whale
Jan 16, 2025
Merged

Backport of Fix Static Role Name Consistency in PostgreSQL Configuration into release/1.18.x#29366
jonathanfrappier merged 1 commit into
release/1.18.xfrom
backport/Correct-static-role-name/mistakenly-noted-whale

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #29138 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Role name is inconsistent in "Rootless Configuration and Password Rotation for Static Roles" Section

The role name specified in allowed_roles="my-role" under the section "Rootless Configuration and Password Rotation for Static Roles" should align with the static role name in step #3. Previously, the command incorrectly used "my-static-role"; it should be "my-role" to match the earlier step.

The same role name should also be used when reading the static credentials in step #4

Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@jonathanfrappier jonathanfrappier merged commit 00faeeb into release/1.18.x Jan 16, 2025
@jonathanfrappier jonathanfrappier deleted the backport/Correct-static-role-name/mistakenly-noted-whale branch January 16, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants