Skip to content

Backport 1.20.x UI: Update namespace key to namespace_path#30869

Merged
davidadeleon merged 1 commit into
release/1.20.xfrom
backport-1.20.x-custom-login-update-namespace-param
Jun 5, 2025
Merged

Backport 1.20.x UI: Update namespace key to namespace_path#30869
davidadeleon merged 1 commit into
release/1.20.xfrom
backport-1.20.x-custom-login-update-namespace-param

Conversation

@hellobontempo
Copy link
Copy Markdown
Contributor

Backport for #30848

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

* change namespace to namespace_path

* VAULT-36846 link jira

* update login settings tests

* fix details param

* update namespace param

* add comment
@hellobontempo hellobontempo added this to the 1.20.0-rc milestone Jun 5, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner June 5, 2025 20:14
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 5, 2025
@hellobontempo hellobontempo changed the title UI: Update namespace key to namespace_path (#30848) Backport 1.20.x UI: Update namespace key to namespace_path Jun 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2025

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2025

CI Results:
All Go tests succeeded! ✅

@davidadeleon davidadeleon merged commit c840f9a into release/1.20.x Jun 5, 2025
35 checks passed
@davidadeleon davidadeleon deleted the backport-1.20.x-custom-login-update-namespace-param branch June 5, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants