Skip to content

UI: Update Swagger Title Element#30888

Merged
lane-wetmore merged 2 commits into
mainfrom
ui/VAULT-32400-Swagger-A11y-Fix
Jun 6, 2025
Merged

UI: Update Swagger Title Element#30888
lane-wetmore merged 2 commits into
mainfrom
ui/VAULT-32400-Swagger-A11y-Fix

Conversation

@lane-wetmore
Copy link
Copy Markdown
Contributor

This PR addresses an a11y violation found in the swagger title.

  • A page header title element has been added to follow a11y hierarchy order and stay consistent with other titles across the UI.

Previous

image

Current

image image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@lane-wetmore lane-wetmore added the ui label Jun 6, 2025
@lane-wetmore lane-wetmore requested a review from a team as a code owner June 6, 2025 17:03
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 6, 2025
@lane-wetmore
Copy link
Copy Markdown
Contributor Author

Wrong ticket branch info - related to this PR #30816

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

Build Results:
All builds succeeded! ✅

@lane-wetmore lane-wetmore added this to the 1.20.0-rc milestone Jun 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

CI Results:
All Go tests succeeded! ✅

@lane-wetmore lane-wetmore merged commit 15a5358 into main Jun 6, 2025
76 of 80 checks passed
@lane-wetmore lane-wetmore deleted the ui/VAULT-32400-Swagger-A11y-Fix branch June 6, 2025 17:39
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
* add h1 page title and update styling
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
* add h1 page title and update styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants