Skip to content

UI: Add missing aria-label to entities alias dropdown#30904

Merged
drivera258 merged 1 commit into
mainfrom
ui/VAULT-32377/fix-missing-accname
Jun 6, 2025
Merged

UI: Add missing aria-label to entities alias dropdown#30904
drivera258 merged 1 commit into
mainfrom
ui/VAULT-32377/fix-missing-accname

Conversation

@drivera258
Copy link
Copy Markdown
Contributor

@drivera258 drivera258 commented Jun 6, 2025

Description

What does this PR do?

Adds missing aria-label to alias name dropdown on Entities page - reported in this a11y ticket

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@drivera258 drivera258 requested a review from a team as a code owner June 6, 2025 19:45
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

CI Results:
All Go tests succeeded! ✅

@drivera258 drivera258 added this to the 1.20.0-rc milestone Jun 6, 2025
@drivera258 drivera258 merged commit 715351b into main Jun 6, 2025
57 of 58 checks passed
@drivera258 drivera258 deleted the ui/VAULT-32377/fix-missing-accname branch June 6, 2025 20:25
drivera258 added a commit that referenced this pull request Jun 11, 2025
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants