Skip to content

Backport of UI: Fix login settings list view if names include an underscore into release/1.20.x#31162

Merged
hellobontempo merged 1 commit into
release/1.20.xfrom
backport/ui/revert-api-service-use-login-settings/recently-grand-marten
Jul 1, 2025
Merged

Backport of UI: Fix login settings list view if names include an underscore into release/1.20.x#31162
hellobontempo merged 1 commit into
release/1.20.xfrom
backport/ui/revert-api-service-use-login-settings/recently-grand-marten

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #31150 to be assessed for backporting due to the inclusion of the label backport/1.20.x.

The below text is copied from the body of the original PR.


Description

Reverts the use of the api service in the login settings list view. The api service camelizes keys which mutates the server response. This means the key_info would not properly map to the key in the keys array. Until we resolve this in the api service itself, reverting the use in the login settings list view.

actual

{
    "key_info": {
        "test_rule": {
            "name": "test_rule",
            "namespace_path": "fake/",
            "disable_inheritance": false
        }
    },
    "keys": [
        "test_rule"
    ]
}

response from request made via api service

{
    "keyInfo": {
        "testRule": {
            "name": "test_rule",
            "namespacePath": "fake/",
            "disableInheritance": false
        }
    },
    "keys": [
        "test_rule"
    ]
}

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hellobontempo hellobontempo added this to the 1.20.1 milestone Jul 1, 2025
@hellobontempo hellobontempo enabled auto-merge (squash) July 1, 2025 16:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 1, 2025

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 1, 2025

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit e6aa2f3 into release/1.20.x Jul 1, 2025
25 of 27 checks passed
@hellobontempo hellobontempo deleted the backport/ui/revert-api-service-use-login-settings/recently-grand-marten branch July 1, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants