Skip to content

Add DB type consts#31295

Merged
elliesterner merged 5 commits into
mainfrom
VAULT-32655/refactor-consts
Jul 17, 2025
Merged

Add DB type consts#31295
elliesterner merged 5 commits into
mainfrom
VAULT-32655/refactor-consts

Conversation

@elliesterner
Copy link
Copy Markdown
Contributor

@elliesterner elliesterner commented Jul 16, 2025

Description

Some CE changes that are necessary for an ENT PR, which adds db plugin census metrics.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@elliesterner elliesterner requested review from a team as code owners July 16, 2025 13:54
@elliesterner elliesterner requested a review from stuti-sr July 16, 2025 13:54
@elliesterner elliesterner added this to the 1.21.0-rc1 milestone Jul 16, 2025
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 16, 2025
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@elliesterner elliesterner requested a review from VioletHynes July 16, 2025 14:36
@elliesterner elliesterner merged commit 1e7f22a into main Jul 17, 2025
90 of 91 checks passed
@elliesterner elliesterner deleted the VAULT-32655/refactor-consts branch July 17, 2025 17:08
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
* add necessary consts

* add other db plugins

* correct ES

* Fix consts in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants