UI: Remove capabilities check from namespace picker refresh list button#31308
Merged
hellobontempo merged 2 commits intoJul 17, 2025
Merged
Conversation
Contributor
Author
|
Build Results: |
|
CI Results: |
hellobontempo
commented
Jul 17, 2025
| ); | ||
| }); | ||
|
|
||
| test('it shows both "Manage" and "Refresh list" action buttons when canList is true', async function (assert) { |
Contributor
Author
hellobontempo
commented
Jul 17, 2025
| this.errorLoadingNamespaces = errorMessage(error); | ||
| } | ||
|
|
||
| await this.fetchListCapability(); |
Contributor
Author
There was a problem hiding this comment.
I didn't see a reason for this to be re-requested when the options are loaded since it's unlikely the capability would need to update when the options change.
drivera258
approved these changes
Jul 17, 2025
9 tasks
hellobontempo
added a commit
that referenced
this pull request
Jul 17, 2025
9 tasks
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The previous namespace picker made a request to sys/namespaces and so “refresh list” was wrapped in the relevant capabilities. The new namespace picker makes a request to sys/internal/ui/namespaces which is an endpoint that any user has access to (it is not policy gated) and so these capabilities do not need to wrap that button.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.