Skip to content

UI: Remove capabilities check from namespace picker refresh list button#31308

Merged
hellobontempo merged 2 commits into
mainfrom
VAULT-38250/update-namespace-picker-capabilities-check
Jul 17, 2025
Merged

UI: Remove capabilities check from namespace picker refresh list button#31308
hellobontempo merged 2 commits into
mainfrom
VAULT-38250/update-namespace-picker-capabilities-check

Conversation

@hellobontempo
Copy link
Copy Markdown
Contributor

Description

The previous namespace picker made a request to sys/namespaces and so “refresh list” was wrapped in the relevant capabilities. The new namespace picker makes a request to sys/internal/ui/namespaces which is an endpoint that any user has access to (it is not policy gated) and so these capabilities do not need to wrap that button.

Screenshot 2025-07-16 at 4 36 45 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@hellobontempo hellobontempo requested a review from a team as a code owner July 16, 2025 23:37
@hellobontempo hellobontempo added this to the 1.20.1 milestone Jul 16, 2025
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 16, 2025
@hellobontempo
Copy link
Copy Markdown
Contributor Author

✅ enterprise tests pass
Screenshot 2025-07-16 at 4 40 16 PM

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

);
});

test('it shows both "Manage" and "Refresh list" action buttons when canList is true', async function (assert) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks bigger than it actually is, i recommend reviewing with ✔️ hide whitespace
Screenshot 2025-07-16 at 5 27 36 PM

this.errorLoadingNamespaces = errorMessage(error);
}

await this.fetchListCapability();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a reason for this to be re-requested when the options are loaded since it's unlikely the capability would need to update when the options change.

@hellobontempo hellobontempo merged commit 6981f47 into main Jul 17, 2025
32 checks passed
@hellobontempo hellobontempo deleted the VAULT-38250/update-namespace-picker-capabilities-check branch July 17, 2025 17:06
lane-wetmore pushed a commit that referenced this pull request Jul 21, 2025
…n fixes (#31330)

* remove sys/namespace capabilities check for refresh button (#31308)

* link jira VAULT-38250

* UI: Fix namespace picker selecting all namespaces with matching nodes (#31326)

* add test

* add changelog

* VAULT-38241 update tests

* restart tests because i closed the PR whyyyy
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants