Skip to content

Backport of UI: Fix namespace picker selecting all namespaces with matching nodes into release/1.20.x#31329

Closed
hc-github-team-secure-vault-core wants to merge 1 commit into
release/1.20.xfrom
backport/VAULT-38241/use-path-as-id-namespace-picker/finally-excited-titmouse
Closed

Backport of UI: Fix namespace picker selecting all namespaces with matching nodes into release/1.20.x#31329
hc-github-team-secure-vault-core wants to merge 1 commit into
release/1.20.xfrom
backport/VAULT-38241/use-path-as-id-namespace-picker/finally-excited-titmouse

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #31326 to be assessed for backporting due to the inclusion of the label backport/1.20.x.

The below text is copied from the body of the original PR.


Description

The namespace picker was using the node as the id key (the segment of the current namespace context) which was used to select a namespace. However, a namespace path could have matching nodes so it may not be a unique value. Updated the namespace picker select a namespace by the full path which is unique.

before fix

image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/VAULT-38241/use-path-as-id-namespace-picker/finally-excited-titmouse branch from 3334fb9 to 04a3b40 Compare July 17, 2025 22:57
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 17, 2025
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results: failed ❌

@hellobontempo
Copy link
Copy Markdown
Contributor

Closing in favor of #31330

@hellobontempo hellobontempo deleted the backport/VAULT-38241/use-path-as-id-namespace-picker/finally-excited-titmouse branch July 17, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants