Skip to content

VAULT-35087: add Open-API support for secret recovery operations#31331

Merged
bosouza merged 3 commits into
mainfrom
bosouza/recover-openapi
Jul 23, 2025
Merged

VAULT-35087: add Open-API support for secret recovery operations#31331
bosouza merged 3 commits into
mainfrom
bosouza/recover-openapi

Conversation

@bosouza
Copy link
Copy Markdown
Contributor

@bosouza bosouza commented Jul 17, 2025

Description

This PR adds support to the secret recovery operations on the API explorer module.

Jira: VAULT-35087

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • [-] LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
    • ] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
      of a public function, even if that change is in a CE file, double check that
      applying the patch for this PR to the ENT repo and running tests doesn't
      break any tests. Sometimes ENT only tests rely on public functions in CE
      files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • [-] RFC: If this change has an associated RFC, please link it in the description.
  • [-] ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • [-] If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • [-] If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 17, 2025
@bosouza bosouza added this to the 1.20.1 milestone Jul 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 17, 2025

CI Results:
All Go tests succeeded! ✅

@bosouza bosouza requested a review from miagilepner July 17, 2025 23:36
@bosouza bosouza marked this pull request as ready for review July 17, 2025 23:36
@bosouza bosouza requested a review from a team as a code owner July 17, 2025 23:36
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

miagilepner
miagilepner previously approved these changes Jul 18, 2025
Copy link
Copy Markdown
Collaborator

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit about the changelog

Comment thread changelog/31331.txt Outdated
Co-authored-by: miagilepner <mia.epner@hashicorp.com>
Copy link
Copy Markdown
Collaborator

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bosouza bosouza merged commit 8f7d76d into main Jul 23, 2025
91 checks passed
@bosouza bosouza deleted the bosouza/recover-openapi branch July 23, 2025 14:33
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
…hicorp#31331)

* support open-api secret recovery operations

* add changelog

* Update changelog/31331.txt

Co-authored-by: miagilepner <mia.epner@hashicorp.com>

---------

Co-authored-by: miagilepner <mia.epner@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants