Skip to content

[UI] Login Settings API Var Casing#31336

Merged
zofskeez merged 1 commit into
mainfrom
ui/more-casing-updates
Jul 18, 2025
Merged

[UI] Login Settings API Var Casing#31336
zofskeez merged 1 commit into
mainfrom
ui/more-casing-updates

Conversation

@zofskeez
Copy link
Copy Markdown
Contributor

Description

This is a follow up from #31325 since API client related vars within config-ui/login-settings were not updated. This fixes that and updates the keyInfoToArray method in the api service as well.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@zofskeez zofskeez added this to the 1.21.0-rc1 milestone Jul 18, 2025
@zofskeez zofskeez requested a review from a team as a code owner July 18, 2025 17:26
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 18, 2025
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@zofskeez zofskeez merged commit 4a76fdc into main Jul 18, 2025
44 checks passed
@zofskeez zofskeez deleted the ui/more-casing-updates branch July 18, 2025 18:09
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants