update alias lookahead to respect case#31352
Merged
Merged
Conversation
* userpass is not case sensitive * ldap is case sensitive when it is configured that way
github-actions
Bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
benashz
reviewed
Jul 22, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if !*cfg.CaseSensitiveNames { |
Contributor
There was a problem hiding this comment.
This looks like another potential nil pointer dereference. You will want to guard against this runtime error with a nil check.
|
|
||
| func (b *backend) pathLoginAliasLookahead(ctx context.Context, req *logical.Request, d *framework.FieldData) (*logical.Response, error) { | ||
| username := d.Get("username").(string) | ||
| username := strings.ToLower(d.Get("username").(string)) |
Contributor
There was a problem hiding this comment.
Can we add some tests for this change?
check for nil and add some tests
and perform nil checks
mickael-hc
force-pushed
the
alias-lookahead-case
branch
from
bf2310e to
c1ab541
Compare
benashz
previously approved these changes
Jul 23, 2025
tomcf-hcp
previously approved these changes
Jul 23, 2025
tomcf-hcp
approved these changes
Jul 23, 2025
4 tasks
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
* userpass is not case sensitive * ldap is case sensitive when it is configured that way --------- Co-authored-by: Ben Ash <bash@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update alias lookahead to respect case:
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist