Skip to content

Backport of Add a note on newlines in indirect reference values in seal configs into release/1.20.x#31354

Open
hc-github-team-secure-vault-core wants to merge 4 commits into
release/1.20.xfrom
backport/sgm/indirect-ref-newlines/frankly-amazing-ewe
Open

Backport of Add a note on newlines in indirect reference values in seal configs into release/1.20.x#31354
hc-github-team-secure-vault-core wants to merge 4 commits into
release/1.20.xfrom
backport/sgm/indirect-ref-newlines/frankly-amazing-ewe

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #31344 to be assessed for backporting due to the inclusion of the label backport/1.20.x.

The below text is copied from the body of the original PR.


Description

What does this PR do?

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/sgm/indirect-ref-newlines/frankly-amazing-ewe branch from 799db71 to c73103c Compare July 22, 2025 17:00
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 22, 2025
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@sgmiller sgmiller added this to the 1.20.1 milestone Jul 22, 2025
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@lursu lursu modified the milestones: 1.20.1, 1.20.2 Jul 24, 2025
@tomcf-hcp tomcf-hcp modified the milestones: 1.20.2, 1.20.3 Aug 7, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vault-ui Ready Ready Preview Comment Sep 29, 2025 4:50pm

@ryancragun
Copy link
Copy Markdown
Collaborator

Copy workflow completed!

From To Skipped Commits Error
hashicorp/vault#31354 hashicorp/vault-enterprise#9728 3

sapk pushed a commit to sapk-fork/vault that referenced this pull request Oct 6, 2025
…in seal configs into release/1.20.x into release/1.20.x+ent (hashicorp#9728) (hashicorp#9730)

* Copy hashicorp#31354 into release/1.20.x+ent




* backport of commit 8309387

---------

Co-authored-by: Ryan Cragun <me@ryan.ec>
Co-authored-by: Scott Miller <smiller@hashicorp.com>
Co-authored-by: Tony Wittinger <anwittin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants