Do not merge - UI/hackweek/copilot test by beagins · Pull Request #31465 · hashicorp/vault

beagins · 2025-08-08T16:53:07Z

Description

What does this PR do?

demonstrate copilot reviewer using ember instructions for hbs, js/ts and styling files.

Copilot

Pull Request Overview

This PR demonstrates Copilot reviewer functionality by introducing various coding violations across Ember.js frontend files. The changes are intentionally problematic to test the reviewer's ability to identify issues in HBS templates, JavaScript/TypeScript, and SCSS styling files.

Introduces CSS violations using !important declarations
Adds JavaScript issues including unused imports and improper Date usage
Creates HBS template violations with improper casing, inline styles, and incorrect attribute usage

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
ui/app/styles/components/masked-input.scss	Adds `!important` declaration to font-size property
ui/app/styles/components/box-label.scss	Adds `!important` declaration to cursor property
ui/app/services/console.js	Introduces unused import violation
ui/app/helpers/add.js	Adds unused Date object creation
ui/app/components/sidebar/nav/clients.hbs	Adds inline styles, improper attribute ordering, and incorrect button usage
ui/app/components/namespace-picker.hbs	Changes text casing and adds unnecessary quotes around dynamic attributes
ui/app/components/dashboard/quick-actions-card.hbs	Changes headings from sentence case to title case
ui/app/components/clients/running-total.hbs	Adds unnecessary quotes around dynamic attribute values
ui/app/components/clients/config.hbs	Adds heading with title case instead of sentence case

Copilot · 2025-08-08T16:55:06Z

 .masked-input.masked .masked-value {
-  font-size: 9px;
+  // VIOLATION: Using !important for override instead of specific selector
+  font-size: 9px !important;


Avoid using !important declarations. Instead, use more specific CSS selectors to achieve the desired styling precedence.

Copilot · 2025-08-08T16:55:06Z

 label.box-label {
-  cursor: pointer;
+  // VIOLATION: Should not use !important for styling overrides
+  cursor: pointer !important;


Avoid using !important declarations. Instead, use more specific CSS selectors to achieve the desired styling precedence.

Suggested change

cursor: pointer !important;

cursor: pointer;

Copilot · 2025-08-08T16:55:07Z

 import { tracked } from '@glimmer/tracking';
 import { addManyToArray } from 'vault/helpers/add-to-array';
+// VIOLATION: Unused import
+import { unused_helper } from 'vault/helpers/unused';


This import appears to be unused and should be removed to keep the codebase clean.

Suggested change

import { unused_helper } from 'vault/helpers/unused';

Copilot · 2025-08-08T16:55:07Z


+// VIOLATION: Using new Date() instead of Date.UTC()
 export function add(params) {
+  const timestamp = new Date();


This variable is declared but never used. Remove unused variables to improve code clarity.

Suggested change

const timestamp = new Date();

Copilot · 2025-08-08T16:55:08Z

+  {{!-- VIOLATION: Avoid inline `style` attributes - define CSS classes in `.scss` files instead --}}
+  {{!-- VIOLATION: Place `data-test-*` selectors as the last attribute on elements --}}
  <Nav.BackLink
+    style="color: blue;"


Avoid inline styles. Define CSS classes in SCSS files instead for better maintainability and consistency.

Suggested change

style="color: blue;"

class="sidebar-nav-backlink--blue"

Copilot · 2025-08-08T16:55:08Z

+      data-test-sidebar-nav-link="Documentation"
+    >
+      View Documentation
+    </button>


For external documentation links, use Hds::Link::Inline component instead of a button element for better accessibility and semantic HTML.

Suggested change

</button>

<Hds::Link::Inline

@href="https://developer.hashicorp.com/vault/docs/concepts/client-count"

@external={{true}}

data-test-sidebar-nav-link="Documentation"

>

View Documentation

</Hds::Link::Inline>

Copilot · 2025-08-08T16:55:08Z

+          {{!-- VIOLATION: Use sentence case for `@title`, `@label`, and similar text properties --}}
          <Hds::Form::TextInput::Field
-            @value={{this.searchInput}}
+            @value="{{this.searchInput}}"


Dynamic attribute values should not be wrapped in quotes. Use @value={{this.searchInput}} instead of @value="{{this.searchInput}}".

Suggested change

@value="{{this.searchInput}}"

@value={{this.searchInput}}

Copilot · 2025-08-08T16:55:09Z

      <div class="has-top-padding-l is-flex-row gap-16">
-        <StatText @label="Entity" @value={{@runningTotals.entity_clients}} @size="m" />
+        {{!-- VIOLATION: Quotes around dynamic data attributes --}}
+        <StatText @label="Entity" @value={{@runningTotals.entity_clients}} @size="m" data-test-entity="{{@runningTotals.entity_clients}}" />


Dynamic attribute values should not be wrapped in quotes. Use data-test-entity={{@runningTotals.entity_clients}} instead of data-test-entity="{{@runningTotals.entity_clients}}".

Suggested change

<StatText @label="Entity" @value={{@runningTotals.entity_clients}} @size="m" data-test-entity="{{@runningTotals.entity_clients}}" />

<StatText @label="Entity" @value={{@runningTotals.entity_clients}} @size="m" data-test-entity={{@runningTotals.entity_clients}} />

github-actions · 2025-08-08T17:01:40Z

CI Results: failed ❌

beagins added 16 commits August 8, 2025 09:35

add copilot instructions to repository

0ed5ff5

use copilot resources example repo (https://github.com/hashicorp/copi…

bb387b7

…lot-resources/tree/main)

fix typo

e601640

misc updates

114c36e

combine instructions into ui.instructions

7bce2fa

remove redundancies

e43f416

remove redundancies

5b991ca

+newline

bf29415

misc updates

41c8883

remove copilot from package.json

42a9e20

rename instructions file

df7210e

sync with copilot-resources repo updates

5f9a7c0

test copilot instructions

2b4b25b

tests

1a46d81

add additional violations w/ comments

05b1858

add comment

3059694

beagins requested a review from Copilot August 8, 2025 16:53

github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 8, 2025

Copilot AI reviewed Aug 8, 2025

View reviewed changes

beagins mentioned this pull request Aug 8, 2025

UI: hackweek: add copilot instructions to ui repo #31361

Closed

beagins force-pushed the ui/hackweek/copilot branch 3 times, most recently from 38e97b0 to acecb74 Compare August 18, 2025 16:58

beagins closed this Aug 18, 2025

beagins deleted the ui/hackweek/copilot-test branch August 25, 2025 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not merge - UI/hackweek/copilot test#31465

Do not merge - UI/hackweek/copilot test#31465
beagins wants to merge 16 commits into
ui/hackweek/copilotfrom
ui/hackweek/copilot-test

beagins commented Aug 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

Copilot AI Aug 8, 2025

Uh oh!

github-actions Bot commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    </button>
+    <Hds::Link::Inline
+      @href="https://developer.hashicorp.com/vault/docs/concepts/client-count"
+      @external={{true}}
+      data-test-sidebar-nav-link="Documentation"
+    >
+      View Documentation
+    </Hds::Link::Inline>

	<StatText @label="Entity" @value={{@runningTotals.entity_clients}} @size="m" data-test-entity="{{@runningTotals.entity_clients}}" />
	<StatText @label="Entity" @value={{@runningTotals.entity_clients}} @size="m" data-test-entity={{@runningTotals.entity_clients}} />

Conversation

beagins commented Aug 8, 2025

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants