UI: Clean up Dynamic UI for CRUD#6994
Conversation
| create: [], | ||
| delete: [], | ||
| navPaths: [], | ||
| }); |
| </p.top> | ||
| <p.levelLeft> | ||
| <h1 class="title is-3"> | ||
| {{capitalize method}} |
There was a problem hiding this comment.
I think I asked about this before - but do we want the method here or the id - and I don’t think we want to capitalize it - I think ldap is better than Ldap.
There was a problem hiding this comment.
method is the id here. naming is weird. I can take out the capitalization though, I agree. I just based it on how we handle this everywhere else
| {{#link-to | ||
| "vault.cluster.access.method.item.create" | ||
| (pluralize itemType) | ||
| tagName="button" |
There was a problem hiding this comment.
Why the button here? Need to look and see if it’s a button elsewhere, but I think it should be an anchor.
| View {{itemType}} | ||
| {{/link-to}} | ||
| </li> | ||
| <li class="action"> |
| {{#if value}} | ||
| <code class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</code> | ||
| {{else}} | ||
| {{#if (eq valueType "array")}} |
There was a problem hiding this comment.
Do we want to show [] or {} if there’s no value for it?
There was a problem hiding this comment.
It looks really weird if it’s just nothing imo. @joshuaogle what do you think?
There was a problem hiding this comment.
Maybe No value assigned? Or even Default value ? (but I’m not sure if there’s no value if it is the default value…). I think we should check for ttl types though - they’re currently showing a {} and I think we don’t want that.
What do you think about leaving these out for now and we can get them in after we talk through the various states - I agree that the blank is strange. Should we default config pages to hide items that are empty maybe?
meirish
left a comment
meirish
left a comment
There was a problem hiding this comment.
This looks good! I had a couple of questions, but I think there were two other things one that came up when I showing UI stuff to @joshuaogle and I didn’t get a chance to circle back to yet.
1 - can we make the link to LDAP from the auth page have black text instead of grey like the others (to show you can click on it)
2 - does this address the routing issue where you click on LDAP in the list and you land on the configuration page? I think this should go to the groups page (or whichever is the first tab).
meirish
left a comment
meirish
left a comment
There was a problem hiding this comment.
Nice - thanks for circling back and getting all of these! Approving, but there’s an open question on what to do with the info-table-row component. I think we should decide on what to do there before merging.
2 participants
address outstanding comments from #6702, general code cleanup