agent/template: give more time for test to poll on directory before f…#7872
Merged
Conversation
catsby
previously approved these changes
Nov 13, 2019
Contributor
catsby
left a comment
catsby
left a comment
There was a problem hiding this comment.
LGTM, thanks @calvn
An alternative could be something like this: https://play.golang.org/p/jvL4iJRLWof but it's just a different style I suppose
Contributor
Author
|
@catsby I like that, updated the logic to use it. Thanks for the suggestion! |
calvn
added a commit
that referenced
this pull request
Dec 6, 2019
#7872) * agent/template: give more time for test to poll on directory before failing * refactor timeout bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ailing