Fix identity token panic during invalidation#8015
Merged
Merged
Conversation
briankassouf
previously approved these changes
Dec 12, 2019
jefferai
requested changes
Dec 12, 2019
Member
jefferai
left a comment
jefferai
left a comment
There was a problem hiding this comment.
Don't know if it's the right fix but seems reasonable.
I'd also like to see some nil checks added to oidcCache though.
added 2 commits
December 12, 2019 17:02
briankassouf
previously approved these changes
Dec 16, 2019
jefferai
reviewed
Dec 16, 2019
| } | ||
|
|
||
| i.oidcCache.Flush(nilNamespace) | ||
| i.oidcCache.Flush(noNamespace) |
Member
There was a problem hiding this comment.
Here (and elsewhere in this PR where you call flush), and in SetDefault below, you've added error returns to the functions but aren't actually checking them here.
briankassouf
approved these changes
Dec 17, 2019
kalafut
pushed a commit
that referenced
this pull request
Dec 17, 2019
* Fix identity token crash during invalidation * Check for nil namespace * Fix test * Add nil check test * Check OIDC cache errors
briankassouf
pushed a commit
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.