Skip to content

builtin/logical/pki: fix JSON tag#8324

Merged
briankassouf merged 1 commit into
hashicorp:masterfrom
alrs:fix-json-tag
Mar 7, 2020
Merged

builtin/logical/pki: fix JSON tag#8324
briankassouf merged 1 commit into
hashicorp:masterfrom
alrs:fix-json-tag

Conversation

@alrs
Copy link
Copy Markdown
Contributor

@alrs alrs commented Feb 10, 2020

omitempty is a valid JSON tag option, but omit_empty is not.

@alrs alrs requested review from jefferai and removed request for jefferai February 21, 2020 20:31
@jefferai jefferai added this to the 1.4 milestone Mar 3, 2020
@jefferai
Copy link
Copy Markdown
Member

jefferai commented Mar 3, 2020

Added to 1.4 milestone although will possibly slip if people don't want to deal with backporting.

Thanks!

@briankassouf briankassouf merged commit ad3110f into hashicorp:master Mar 7, 2020
briankassouf pushed a commit that referenced this pull request Mar 7, 2020
briankassouf added a commit that referenced this pull request Mar 7, 2020
Co-authored-by: Lars Lehtonen <lars.lehtonen@gmail.com>
andaley pushed a commit that referenced this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants