Create configutil and move some common config and setup functions there#8362
Merged
Conversation
jefferai
force-pushed
the
configutil
branch
27 times, most recently
from
1c56739 to
b7caef4
Compare
calvn
reviewed
May 11, 2020
Contributor
calvn
left a comment
calvn
left a comment
There was a problem hiding this comment.
Took a first pass review at this, and it looks great! Left mostly minor comments, but I'll circle back at some point later in time to go through things once again.
Contributor
briankassouf
left a comment
briankassouf
left a comment
There was a problem hiding this comment.
All pretty minor comments/questions
Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>
Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>
Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>
briankassouf
previously approved these changes
May 13, 2020
Contributor
briankassouf
left a comment
briankassouf
left a comment
There was a problem hiding this comment.
Thanks for applying those changes
briankassouf
approved these changes
May 14, 2020
Member
Author
|
See #8996 -- maybe see if you're good with that before I merge? Then I'll merge that to here, then merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.