Add Core Usage Metrics Components to Storybook#8401
Merged
Conversation
chelshaw
reviewed
Feb 21, 2020
andaley
reviewed
Feb 21, 2020
Contributor
andaley
previously approved these changes
Feb 21, 2020
Contributor
Author
|
@noelledaley These are great comments, thank you. I went ahead and removed |
chelshaw
approved these changes
Mar 2, 2020
Monkeychip
added a commit
that referenced
this pull request
Mar 2, 2020
* add core usage metrics components to storybook, rename component from small to simple * remove const from js file * remove grid container knob from selectable-card
Monkeychip
added a commit
that referenced
this pull request
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is a follow up of the Core Usage Metrics project, released in 1.4. For that project, we created 3 new components. This PR adds those components to Storybook.
Additionally, this PR:
HttpRequestsBarChartSmalltoHttpRequestsBarChartSimple. This makes more sense when viewing from Storybook. See screenshot.My prettier configuration automatically reformatted the
http-requests-bar-chart.stories.jsfile. I agree with the formatting changes, and so am committing them in this PR.I double-checked that the renamed component still shows on the UI as it did before.
Here is a gif of the 3 new components on Storybook.

Also, I believe this should be a 1.4.1 milestone, but let me know if that's incorrect.