Conversation
catsby
approved these changes
Mar 9, 2020
| - `certificate` `(string: "")` – CA certificate to use when verifying LDAP server | ||
| certificate, must be x509 PEM encoded. | ||
| - `client_tls_cert` `(string "")` - Client certificate to provide to the LDAP | ||
| server, must be x509 PEM encoded (optional). |
Contributor
There was a problem hiding this comment.
Suggested change
| server, must be x509 PEM encoded (optional). | |
| server. Must be x509 PEM encoded (optional). |
| - `client_tls_cert` `(string "")` - Client certificate to provide to the LDAP | ||
| server, must be x509 PEM encoded (optional). | ||
| - `client_tls_key` `(string "")` - Client certificate key to provide to the LDAP | ||
| server, must be x509 PEM encoded (optional). |
Contributor
There was a problem hiding this comment.
Suggested change
| server, must be x509 PEM encoded (optional). | |
| server. Must be x509 PEM encoded (optional). |
Contributor
There was a problem hiding this comment.
Well, I guess this , must be format is consistent with the rest of the docs, but it reads funny to me. Accept or decline as you will
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New options for 1.4