Add option to detect deadlocks in Core.stateLock using build tag deadlock#8524
Merged
Conversation
briankassouf
previously approved these changes
Mar 10, 2020
kalafut
reviewed
Mar 10, 2020
| quitCh chan struct{} | ||
|
|
||
| coreStateLock *sync.RWMutex | ||
| coreStateLock *DeadlockMutexRW |
Contributor
There was a problem hiding this comment.
Could you add a comment here about the buildtag-conditional behavior, as well as what one should expect if the deadlock detection is enabled?
Collaborator
Author
There was a problem hiding this comment.
Good call, but I think I'd rather put the comment next to the type definition(s), since we may wind up using this in other places than just stateLock. Would that be acceptable?
calvn
reviewed
Mar 10, 2020
| "github.com/sasha-s/go-deadlock" | ||
| ) | ||
|
|
||
| // DeadlockMutexW, when the build tag `deadlock` is present, behaves like a |
Contributor
There was a problem hiding this comment.
Small nit, why not call it DeadlockMutex (and DeadlockRWMutex)?
Collaborator
Author
There was a problem hiding this comment.
I don't remember what my rationale was, so I'll change it to be the more natural way as you suggest.
calvn
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.