Skip to content

Backport 1.4.x: Always pick us-east-1 for the "aws" partition#8680

Merged
tyrannosaurus-becks merged 1 commit into
release/1.4.xfrom
backport-pr-8679-1.4.x
Apr 9, 2020
Merged

Backport 1.4.x: Always pick us-east-1 for the "aws" partition#8680
tyrannosaurus-becks merged 1 commit into
release/1.4.xfrom
backport-pr-8679-1.4.x

Conversation

@tyrannosaurus-becks
Copy link
Copy Markdown
Contributor

This PR backports #8679 to include it in our next Vault release.

* always pick us-east-1 for aws partition

* Update builtin/credential/aws/backend.go

Co-Authored-By: Jim Kalafut <jkalafut@hashicorp.com>

Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
@tyrannosaurus-becks tyrannosaurus-becks added this to the 1.4.1 milestone Apr 3, 2020
@tyrannosaurus-becks tyrannosaurus-becks added bug Used to indicate a potential bug auth/aws labels Apr 3, 2020
Copy link
Copy Markdown
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tyrannosaurus-becks tyrannosaurus-becks merged commit 882a39e into release/1.4.x Apr 9, 2020
@tyrannosaurus-becks tyrannosaurus-becks deleted the backport-pr-8679-1.4.x branch April 9, 2020 16:12
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Sep 2, 2025
…ashicorp#8728)

* add copilot instructions to repository

use copilot resources example repo (https://github.com/hashicorp/copilot-resources/tree/main)

* address PR comments (hashicorp#31361)

Co-authored-by: Shannon Roberts (Beagin) <beagins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth/aws bug Used to indicate a potential bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants