Skip to content

Add docs for password policies#8974

Merged
pcman312 merged 10 commits into
masterfrom
docs/password-policies
Jun 2, 2020
Merged

Add docs for password policies#8974
pcman312 merged 10 commits into
masterfrom
docs/password-policies

Conversation

@pcman312
Copy link
Copy Markdown
Contributor

@pcman312 pcman312 commented May 11, 2020

Overview

Adds docs for #8637

Added a section to "Concepts"

  • Describes how it works, how candidate passwords are generated, policy syntax, general performance characteristics, and available rules (just charset)

Also added a section to API docs under system backend

@pcman312 pcman312 marked this pull request as ready for review May 20, 2020 16:15
@pcman312 pcman312 requested a review from a team May 20, 2020 16:17
Copy link
Copy Markdown
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work here, the password generation process explanation was easy to follow and informative. Mostly minor grammar suggestions, and a couple questions.

Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx
Comment thread website/pages/api-docs/system/policies-password.mdx
Comment thread website/pages/api-docs/system/policies-password.mdx Outdated
@Valarissa
Copy link
Copy Markdown

@tvoran has a much better eye than I do for details, lol. Everything made sense and seemed clear to me, but many of the points made by him are super valuable. I'll leave this in his capable hands. :) Great work overall though!

@pcman312
Copy link
Copy Markdown
Contributor Author

Thanks @tvoran & @Valarissa ! I've updated per your comments.

@tvoran tvoran self-requested a review May 27, 2020 22:05
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
Comment thread website/pages/docs/concepts/password-policies.mdx Outdated
@pcman312 pcman312 added the docs label Jun 2, 2020
@pcman312 pcman312 merged commit e568432 into master Jun 2, 2020
@pcman312 pcman312 deleted the docs/password-policies branch June 2, 2020 17:12
andaley pushed a commit that referenced this pull request Jul 17, 2020
* Add docs for password policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants