Add mongodbatlas static roles support #8987
Merged
Merged
Conversation
Collaborator
Author
|
Note that for once I broke the changes into meaningful changesets, so it might be easier to review this by looking at them individually. |
ncabatoff
changed the title
ncabatoff
changed the title
…not the users exist beforehand, and bump the dependency so the test passes.
Collaborator
Author
|
This is ready to go as soon as I sort out whether my go.mod update without tag is kosher. |
ncabatoff
changed the title
Collaborator
Author
|
Fixes #8966. |
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* Refactor PG container creation. * Rework rotation tests to use shorter sleeps. * Refactor rotation tests. * Add a static role rotation test for MongoDB Atlas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I incorporated some of my changes from my docker-test branch that weren't actually specific to testing with docker. They made these changes easier by allowing me to pre-create the PG container and have the rotation tests complete in 30s instead of several minutes.
The needed env var settings to run this test have been added to 1p. I'd like to add them to CircleCI as well if folks are ok with that.
Note that the test will fail until we apply hashicorp/vault-plugin-database-mongodbatlas#11.