secrets/database: return any error from rotations#8997
Merged
Conversation
michelvocks
approved these changes
May 19, 2020
catsby
added a commit
that referenced
this pull request
May 19, 2020
catsby
added a commit
that referenced
this pull request
May 19, 2020
pull Bot
pushed a commit
to Zezo-Ai/vault
that referenced
this pull request
Sep 3, 2025
…hicorp#8997) * updates display attrs for auth method configs * fixes plugin identity util fields tests * adds comments explaining variadic operator choice * stubs original automatedrotation and pluginidentity util functions * updates group name in TestAddPluginIdentityTokenFieldsWithGroup --------- Co-authored-by: Jordan Reimer <jordan.reimer@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rotating credentials, if the call to
setStaticAccountto rotate the credentials of a static account were to fail (ex. read-only storage) the role gets an updated priority and placed back on the queue to try again. The error returned fromsetStaticAccountgets lost and is not returned, which could result in a200type API response even though the operation actually failed.This change makes sure we return any error from
setStaticAccountRelated to #8105