Skip to content

update deps for security#9039

Merged
andaley merged 5 commits into
masterfrom
ui/fix-security-alerts
May 21, 2020
Merged

update deps for security#9039
andaley merged 5 commits into
masterfrom
ui/fix-security-alerts

Conversation

@andaley
Copy link
Copy Markdown
Contributor

@andaley andaley commented May 19, 2020

This PR updates a few dependencies to resolve security alerts. These are primarily used in test and dev environments so should not need to be backported.

@andaley andaley added the ui label May 19, 2020
@andaley andaley requested a review from a team May 19, 2020 23:59
@andaley andaley added this to the 1.4.2 milestone May 19, 2020
@mladlow
Copy link
Copy Markdown
Contributor

mladlow commented May 20, 2020

Since there won't be a backport, I'm going to change the milestone to 1.5.

@mladlow mladlow modified the milestones: 1.4.2, 1.5 May 20, 2020
Copy link
Copy Markdown
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! There appears to be some failing UI tests. If you need help problem solving these, I'd be happy to help investigate.

Copy link
Copy Markdown
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix test (changing my previous review)

@andaley andaley force-pushed the ui/fix-security-alerts branch from 78ca5d5 to 69bee6b Compare May 21, 2020 00:03
@andaley andaley force-pushed the ui/fix-security-alerts branch from 2ff023d to 8328b85 Compare May 21, 2020 22:33
Copy link
Copy Markdown
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andaley andaley merged commit aaf7245 into master May 21, 2020
@andaley andaley deleted the ui/fix-security-alerts branch May 21, 2020 23:12
pull Bot pushed a commit to NOUIY/vault that referenced this pull request Sep 2, 2025
…p#9031) (hashicorp#9039)

* adding plugin settings tab and route

* updating plugin settings

* removing current when for secret engine nav link

* fix tab name

* adding empty state

Co-authored-by: Dan Rivera <dan.rivera@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants