Skip to content

agent/template: update consul-template dep#9044

Merged
jasonodonnell merged 1 commit into
masterfrom
fix-consul-template-race
May 20, 2020
Merged

agent/template: update consul-template dep#9044
jasonodonnell merged 1 commit into
masterfrom
fix-consul-template-race

Conversation

@jasonodonnell
Copy link
Copy Markdown
Contributor

A race condition exists when exit_after_auth: true is enabled with Agent templating where Agent doesn't wait for all commands to finish before exiting. This was due to CT sending a done signal for all templates being rendered. This has been fixed upstream in this commit hashicorp/consul-template#1370.

In newer version of CT, Name was removed from the configuration struct, so I removed it from Vault Agent.

@jasonodonnell jasonodonnell requested a review from a team May 20, 2020 15:33
@briankassouf briankassouf added this to the 1.4.2 milestone May 20, 2020
@jasonodonnell jasonodonnell merged commit dbaa9ec into master May 20, 2020
@jasonodonnell jasonodonnell deleted the fix-consul-template-race branch May 20, 2020 17:03
@mladlow mladlow modified the milestones: 1.4.2, 1.5 May 20, 2020
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Sep 2, 2025
* portion of changes for autoloading

* add test checking for panic

* add endpoint for force unloading

* separate method for force unload

* changelog

* don't redefine constants

* fix constant

* first pass at autoloading

* only reload every hour

* add autoload interval

* enable modifying the min interval for testing

* revert incorrectly modified file

* small fixes

* allow reloading from an autoload

* check for nil manager

* fix incorrect updates

* additional test, add godocs

* changelog

* fix more constants

* fix panic

* formatting

* godoc for test

Co-authored-by: miagilepner <mia.epner@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants