Extend agent template tests to also validate that updated templates get re-rendered#9097
Merged
Merged
Conversation
catsby
approved these changes
May 28, 2020
Contributor
catsby
left a comment
catsby
left a comment
There was a problem hiding this comment.
👍 one question but not a blocker, just curious
| // make some template files | ||
| var templatePaths []string | ||
| for i := 0; i < tc.templateCount; i++ { | ||
| path := makeTempFile(t, fmt.Sprintf("render_%d", i), templateContents(i)) |
Contributor
There was a problem hiding this comment.
Any particular reason to not use makeTempFile here?
Collaborator
Author
There was a problem hiding this comment.
When I was debugging it was easier to have the inputs and outputs in the same directory and using the same basename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.