Skip to content

docs: add missing kubernetes role verb#9110

Closed
bchrobot wants to merge 1 commit into
hashicorp:masterfrom
bchrobot:patch-1
Closed

docs: add missing kubernetes role verb#9110
bchrobot wants to merge 1 commit into
hashicorp:masterfrom
bchrobot:patch-1

Conversation

@bchrobot
Copy link
Copy Markdown
Contributor

@bchrobot bchrobot commented May 31, 2020

The patch verb is required to update labels for the Service Registration feature.

The `patch` verb is required for Service Registration (at least it is in Kubernetes server version 1.15)
@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented May 31, 2020

CLA assistant check
All committers have signed the CLA.

@headcr4sh
Copy link
Copy Markdown

Duplicate of PR #9073

@pbernal
Copy link
Copy Markdown
Contributor

pbernal commented Jun 12, 2020

Thank you @bchrobot for your contribution here, and thank you for referencing the duplicate @headcr4sh
I will have the previous PR reviewed by our team, and will be closing out this issue. Have a great day!

@pbernal pbernal closed this Jun 12, 2020
@bchrobot bchrobot deleted the patch-1 branch June 12, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants