Replication Sidebranch: Management Actions#9120
Merged
Monkeychip merged 7 commits intoJun 10, 2020
Merged
Conversation
Set up dr-secondary management page with new action flow * Create confirmation-modal component * Refactor replication-dr-secondary splash page to replication manage page * Refactor replication-action-disable component to use confirmation modal * Add details/manage tab to replication-dr-secondary section
chelshaw
force-pushed
the
ui/replication-mgmt-sidebranch
branch
from
77a0fcd to
77c7f31
Compare
* do not show replication mode or id when replication isn't enabled * fix broken tag * fill in confirmation text when disabling replication in tests * fix typo * fix demote primary test selector * add test selectors and update tests to match new format * fill in Performance when disabling performance secondary
* Update Primary replication action uses modal flow * Update modal max-height to accommodate for the navbar
2 tasks
chelshaw
commented
Jun 9, 2020
chelshaw
commented
Jun 9, 2020
| @showCloseButton={{true}} | ||
| > | ||
| <section class="modal-card-body"> | ||
| <div class="box is-shadowless is-fullwidth is-sideless"> |
Contributor
Author
There was a problem hiding this comment.
This wrapping div can also be removed @noelledaley @Monkeychip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the management sidebranch to be merged into the replication sidebranch when the work is finished. The management pages exist for all types of replication (DR primary, DR secondary, Perf primary, Perf secondary).
Tasks to complete before merging:
// These have been moved into separate tickets that will be addressed after the merge.