Skip to content

Integrate password policies into RabbitMQ secret engine#9143

Merged
pcman312 merged 8 commits into
masterfrom
rabbitmq-password-policies
Jun 11, 2020
Merged

Integrate password policies into RabbitMQ secret engine#9143
pcman312 merged 8 commits into
masterfrom
rabbitmq-password-policies

Conversation

@pcman312
Copy link
Copy Markdown
Contributor

@pcman312 pcman312 commented Jun 3, 2020

  • Integrates password policies into the RabbitMQ secret engine
    • password_policy field is optional. If not specified, it defaults to using the base62 package instead of a uuid as a password.
  • Updates docs for RabbitMQ
    • Tabified the API docs for RabbitMQ to show both cURL & Vault CLI commands

Copy link
Copy Markdown
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some style questions so far.

Comment thread builtin/logical/rabbitmq/path_config_connection.go Outdated
Comment thread builtin/logical/rabbitmq/path_config_connection.go Outdated
Comment thread builtin/logical/rabbitmq/backend_test.go Outdated
tvoran
tvoran previously approved these changes Jun 10, 2020
@pcman312 pcman312 merged commit b2441ef into master Jun 11, 2020
@pcman312 pcman312 deleted the rabbitmq-password-policies branch June 11, 2020 22:08
catsby added a commit that referenced this pull request Jun 15, 2020
* master: (36 commits)
  Minor transform docs rewording (#9223)
  Validate physical CockroachDB table config value before using it (#9191)
  Validate physical MySQL database and table config values before using them (#9189)
  add disable_iss_validation option to k8s auth docs (#9142)
  fix: configutil redeclared as imported package name (#9211)
  Integrate password policies into RabbitMQ secret engine (#9143)
  Clarify cache setting. (#9204)
  Test pre-1.4 seal migration  (#9085)
  Simple typos (#9119)
  Update contribution guidelines
  changelog++
  Add ssh signing algorithm as a role option.   (#9096)
  replacing "a key usage mode" as it is confusing (#9194)
  changelog++
  fix: invalidate cached clients after a config change in the aws secrets backend (#9186)
  website: remove whitepaper link from subnav (#9190)
  changelog++
  Improving transit batch encrypt and decrypt latencies (#8775)
  changelog++
  AWS: Add iam_groups parameter to role create/update (#8811)
  ...
andaley pushed a commit that referenced this pull request Jul 17, 2020
* Add password policies to RabbitMQ & update docs
* Also updates some parts of the password policies to aid/fix testing
eualin pushed a commit to eualin/vault that referenced this pull request Sep 16, 2025
…p#9143) (hashicorp#9259)

Co-authored-by: Eren Tantekin <eren.tantekin@hashicorp.com>
Co-authored-by: Jim Wright <jim.wright@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants