Skip to content

Sync Protobuf dependencies between core and sdk#9154

Merged
catsby merged 3 commits into
masterfrom
protobuf-sync
Jun 5, 2020
Merged

Sync Protobuf dependencies between core and sdk#9154
catsby merged 3 commits into
masterfrom
protobuf-sync

Conversation

@catsby
Copy link
Copy Markdown
Contributor

@catsby catsby commented Jun 5, 2020

This PR synchronizes the version of protocol buffers and associate libraries used in core and the sdk to be on the same versions.

github.com/golang/protobuf v1.4.2 -> https://github.com/golang/protobuf
google.golang.org/protobuf v1.24.0 -> https://github.com/protocolbuffers/protobuf-go

@catsby catsby requested review from briankassouf and jefferai June 5, 2020 13:27
@catsby catsby added this to the 1.5 milestone Jun 5, 2020
@catsby catsby added dependencies Pull requests that update a dependency file enhancement and removed enhancement labels Jun 5, 2020
@catsby catsby merged commit a0aa93d into master Jun 5, 2020
catsby added a commit that referenced this pull request Jun 5, 2020
* master:
  Sync Protobuf dependencies between core and sdk (#9154)
  Document and give an example of the input size limits when using the FF3-1 transform. (#9151)
  Fix feature flag persistence: we shouldn't have excluded dr primaries, they too must write feature flags. DR secondaries might not need depend on feature flags being there, but a DR primary could also be (or become) a perf primary. (#9148)
andaley pushed a commit that referenced this pull request Jul 17, 2020
* update go.mod/sum for root and sdk folders to sync protobuf versions

* run 'go mod vendor'

* bump github.com/golang/protobuf to v1.4.2
eualin pushed a commit to eualin/vault that referenced this pull request Sep 5, 2025
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants