Skip to content

Add new Telemetry config options#9238

Merged
sgmiller merged 11 commits into
masterfrom
addntl-telemetry-config
Jun 17, 2020
Merged

Add new Telemetry config options#9238
sgmiller merged 11 commits into
masterfrom
addntl-telemetry-config

Conversation

@sgmiller
Copy link
Copy Markdown
Collaborator

@sgmiller sgmiller commented Jun 16, 2020

Add maximum_gauge_cardinality, and usage_gauge_period
configuration options to the config stanza.

Update unit tests.

Document.

sgmiller added 3 commits June 16, 2020 10:21
Add cluster_name, maximum_gauge_cardinality, and usage_gauge_period
configuration options to the config stanza.

Update unit tests.

Document.
@sgmiller sgmiller added the website Code changes specifically for the docs website label Jun 16, 2020
@sgmiller sgmiller requested a review from mgritter June 16, 2020 15:53
Comment thread internalshared/configutil/telemetry.go Outdated
Comment thread website/pages/docs/configuration/telemetry.mdx Outdated
Copy link
Copy Markdown
Contributor

@mgritter mgritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc suggestion

@sgmiller sgmiller requested a review from mgritter June 16, 2020 17:07
Copy link
Copy Markdown
Contributor

@mgritter mgritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread command/server.go Outdated
Comment thread internalshared/configutil/telemetry.go Outdated
Copy link
Copy Markdown
Contributor

@mgritter mgritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sgmiller sgmiller merged commit 2648713 into master Jun 17, 2020
@sgmiller sgmiller deleted the addntl-telemetry-config branch June 17, 2020 15:07
catsby added a commit that referenced this pull request Jun 19, 2020
* master: (31 commits)
  changelog++
  changelog++
  Ui/replication status discoverability (#8705)
  Update CHANGELOG.md
  Counter that increments on every secret engine lease creation. (#9244)
  Add password_policy field to Azure docs (#9249)
  Replaced ClusterMetricSink's cluster name with an atomic.Value. (#9252)
  Fix database creds rotation panic for nil resp (#9258)
  changelog++
  changelog++
  Move sdk/helper/random -> helper/random (#9226)
  UI: Disallow kv2 with too large 'max versions' value (#9242)
  Allow mTLS for mysql secrets engine (#9181)
  docs: add sample revocation for mongodb (#9245)
  Add new Telemetry config options (#9238)
  Add a simple sealed gauge, updated when seal status changes (#9177)
  Test Shamir-to-Transit and Transit-to-Shamir Seal Migration for post-1.4 Vault. (#9214)
  Configure metrics wrapper with the "global" object, not just the fanout. (#9099)
  changelog++
  Add backend type to audit logs (#9167)
  ...
andaley pushed a commit that referenced this pull request Jul 17, 2020
* Add new Telemetry config options

Add cluster_name, maximum_gauge_cardinality, and usage_gauge_period
configuration options to the config stanza.

Update unit tests.

Document.

Co-authored-by: Mark Gritter <mgritter@hashicorp.com>
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Sep 11, 2025
Co-authored-by: kelly <69541941+kporter101@users.noreply.github.com>
anwittin pushed a commit that referenced this pull request Sep 18, 2025
Co-authored-by: kelly <69541941+kporter101@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website Code changes specifically for the docs website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants