Improve the performance of snapshot installs by using rename#9247
Merged
Conversation
added 9 commits
May 20, 2020 14:40
calvn
reviewed
Jun 18, 2020
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Changes look like they follow the RFC 👍
raskchanky
reviewed
Jun 18, 2020
added 2 commits
June 18, 2020 16:41
raskchanky
reviewed
Jun 18, 2020
Collaborator
raskchanky
left a comment
raskchanky
left a comment
There was a problem hiding this comment.
Reading through all of this was very educational. Thanks for the clarifications on my questions.
calvn
approved these changes
Jun 19, 2020
Contributor
calvn
left a comment
calvn
left a comment
There was a problem hiding this comment.
Took another look at it, and got nothing else to add, 👍 !
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Performed another review, looks great @briankassouf. Left some minor questions & comments.
| atomic.StoreUint64(f.latestIndex, metadata.Index) | ||
| atomic.StoreUint64(f.latestTerm, metadata.Term) | ||
| f.latestConfig.Store(protoConfig) | ||
| f.latestConfig.Store(raftConfigurationToProtoConfiguration(metadata.ConfigurationIndex, metadata.Configuration)) |
Contributor
There was a problem hiding this comment.
nit: raftConfigToProtoConfig slightly shorter nomenclature
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
catsby
added a commit
that referenced
this pull request
Jun 24, 2020
* master: Entity and alias counts (#9262) Token gauge metrics implementation. (#9239) mfa: fix import path on test file (#9303) doc: update vault helm enterprise image examples (#9299) raft: add support for using backend for ha_storage (#9193) Document new and previously undocumented telemetry metrics: (#9283) Improve the performance of snapshot installs by using rename (#9247) docs: add additional info around transform for tweak and template type (#9203) Update CHANGELOG.md CL++: Add go version to server message output
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* initial work on improving snapshot performance * Work on snapshots * rename a few functions * Cleanup the snapshot file * vendor the safeio library * Add a test * Add more tests * Some review comments * Fix comment * Update physical/raft/snapshot.go Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Update physical/raft/snapshot.go Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Review feedback Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the snapshot store away from using flat files to using newly written boltDB files for snapshot data. This allows us to do an atomic rename when that snapshot needs to be installed to the FSM instead of doing another copy of the data.