Backport 1.4: Add ssh signing algorithm as a role option#9266
Merged
Conversation
sgmiller
approved these changes
Jun 22, 2020
pull Bot
pushed a commit
to Reality2byte/vault
that referenced
this pull request
Sep 11, 2025
…ashicorp#9266) * add responses to the three endpoints * add responses for the rest of the endpoints * more changes * use standard definitions for responses * normalize complex fields of type structs into standard json types of slices and maps * fix normalization of total * add normalization to partial month endpoint too * fix linters * add bad request and server error schema types to monthly endpoint * add validation tests * fix linters error * upgrade dependency * make query parameters explicit * add changelog * define by namespace fields as a slice, not a map * define times as Time type instead of string * remove normalizations Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.