docs: clarify when plugin executables must also be given mlock syscall ability#9275
Merged
Conversation
catsby
approved these changes
Jun 22, 2020
Contributor
catsby
left a comment
catsby
left a comment
There was a problem hiding this comment.
👍 we should also fix the formatting of the existing Note you mention, it doesn't have the ~> that triggers the CSS styling of a note
Contributor
Author
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9257
This PR adds a note to the internals/plugins documentation to clarify when plugin executables must also be given the
mlocksyscall ability. It's not obvious that this is needed from the plugin documentation.There currently is documentation stating that this is needed, but it's somewhat difficult to find in configuration#disable_mlock. See:
I plan to update the ops-deployment-guide to mention this as well.