sdk: simplify parseutil handling of json data#9345
Closed
greut wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Contributor
|
As this PR is older and cannot currently be merged due to merge conflicts, I’m going to go ahead and close it. Please feel free to open a new PR if your desired changes are still applicable! |
pull Bot
pushed a commit
to Zezo-Ai/vault
that referenced
this pull request
Sep 19, 2025
…mages on HCP into ce/main (#9433) [VAULT-39160] actions(hcp): add support for testing custom images on HCP (hashicorp#9345) Add support for running the `cloud` scenario with a custom image in the int HCP environment. We support two new tags that trigger new functionality. If the `hcp/build-image` tag is present on a PR at the time of `build`, we'll automatically trigger a custom build for the int environment. If the `hcp/test` tag is present, we'll trigger a custom build and run the `cloud` scenario with the resulting image. * Fix a bug in our custom build pattern to handle prerelease versions. * pipeline(hcp): add `--github-output` support to `show image` and `wait image` commands. * enos(hcp/create_vault_cluster): use a unique identifier for HVN and vault clusters. * actions(enos-cloud): add workflow to execute the `cloud` enos scenario. * actions(build): add support for triggering a custom build and running the `enos-cloud` scenario. * add more debug logging and query without a status * add shim build-hcp-image for CE workflows Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
anwittin
pushed a commit
that referenced
this pull request
Sep 19, 2025
… custom images on HCP into release/1.20.x+ent into ce/release/1.20.x (#9439) * [VAULT-39160] actions(hcp): add support for testing custom images on HCP (#9345) Add support for running the `cloud` scenario with a custom image in the int HCP environment. We support two new tags that trigger new functionality. If the `hcp/build-image` tag is present on a PR at the time of `build`, we'll automatically trigger a custom build for the int environment. If the `hcp/test` tag is present, we'll trigger a custom build and run the `cloud` scenario with the resulting image. * Fix a bug in our custom build pattern to handle prerelease versions. * pipeline(hcp): add `--github-output` support to `show image` and `wait image` commands. * enos(hcp/create_vault_cluster): use a unique identifier for HVN and vault clusters. * actions(enos-cloud): add workflow to execute the `cloud` enos scenario. * actions(build): add support for triggering a custom build and running the `enos-cloud` scenario. * add more debug logging and query without a status * add shim build-hcp-image for CE workflows Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while reading that code; it seemed that some simplifications could be done.
ParseInt