Address feedback on Plugin Reload: OSS Side#9350
Merged
Merged
Conversation
calvn
approved these changes
Jun 30, 2020
Contributor
calvn
left a comment
calvn
left a comment
There was a problem hiding this comment.
Looks good!
Should we condense the output to simply be this? I'm also fine as-is if that makes more sense.
out := []string{"Time | Participant | Error "}
sgmiller
added a commit
that referenced
this pull request
Jun 30, 2020
* just use an error string * Switch command to use new struct
sgmiller
added a commit
that referenced
this pull request
Jul 6, 2020
* Global Plugin Reload: OSS Changes Take II (#9347) * Carefully move changes from the plugin-cluster-reload branch into this clean branch off master. * Don't test this at this level, adequately covered in the api level tests * Change PR link * go.mod * Vendoring * Vendor api/sys_plugins.go * Fix wrong err return value in plugin reload status command (#9348) * Fix wrong return value (discovered when merging to ENT) * go.mod * go mod vendor * Add setup plugin reload hook * All reloads return something now * Address feedback on Plugin Reload: OSS Side (#9350) * just use an error string * Switch command to use new struct * Don't setup plugin reload on perf standbys (#9352)
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* just use an error string * Switch command to use new struct
pull Bot
pushed a commit
to Zezo-Ai/vault
that referenced
this pull request
Sep 16, 2025
…ashicorp#9350) (hashicorp#9353) Co-authored-by: Shannon Roberts (Beagin) <beagins@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.