Skip to content

Backport 1.5.x: Update TTL picker on add replication secondary (#9271)#9368

Merged
chelshaw merged 1 commit into
release/1.5.xfrom
backport-pr-9271-1.5.x
Jul 1, 2020
Merged

Backport 1.5.x: Update TTL picker on add replication secondary (#9271)#9368
chelshaw merged 1 commit into
release/1.5.xfrom
backport-pr-9271-1.5.x

Conversation

@chelshaw
Copy link
Copy Markdown
Contributor

@chelshaw chelshaw commented Jul 1, 2020

This change updates the TTL picker to the new version to match most updated designs. The component also allows the default value to be more obvious. Original PR: #9271

BEFORE
ttl-secondary-old

AFTER (default)
replication-secondary-ttl-default

AFTER (enabled/custom)
replication-secondary-ttl-enabled

* Update TTL picker on add replication secondary

This change updates the TTL picker to the new version to match most updated designs. The component also allows the default value to be more obvious

* Remove erroneous else

* Add changeOnInit param for TtlPicker2 and use it on add secondary page

* Update ttlPicker2 docs and add tests for new param

* Calculate value in unit provided on init for ttl-picker2, with tests

* Cleanup and make ttl-picker2 test more specific
@chelshaw chelshaw added this to the 1.5 milestone Jul 1, 2020
@chelshaw chelshaw merged commit dd4299c into release/1.5.x Jul 1, 2020
@chelshaw chelshaw deleted the backport-pr-9271-1.5.x branch July 1, 2020 18:48
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Sep 16, 2025
…hashicorp#9368)

* Add role rotation info to create/update observations

* observatin enhancements

* observatin enhancements

* remove log

* duration strings instead of seconds

* the stringening

* more times

* credential type

* Add rotation schedule/period to root rotation

* more ttls

* updates

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants