Skip to content

Add nil check for quota manager#9379

Merged
calvn merged 4 commits into
masterfrom
core/handle-nil-quota-mngr
Jul 2, 2020
Merged

Add nil check for quota manager#9379
calvn merged 4 commits into
masterfrom
core/handle-nil-quota-mngr

Conversation

@alexanderbez
Copy link
Copy Markdown
Contributor

No description provided.

@alexanderbez alexanderbez marked this pull request as ready for review July 1, 2020 22:40
@mjarmy mjarmy added this to the 1.5 milestone Jul 1, 2020
@calvn
Copy link
Copy Markdown
Contributor

calvn commented Jul 1, 2020

We should also nil check in these places:

if err := c.quotaManager.HandleBackendDisabling(ctx, ns.Path, path); err != nil {

if err := c.quotaManager.HandleBackendDisabling(ctx, ns.Path, path); err != nil {

@calvn calvn added the backport label Jul 1, 2020
@calvn calvn merged commit dc49230 into master Jul 2, 2020
calvn pushed a commit that referenced this pull request Jul 2, 2020
* Add nil check for quota manager

* Add missing nil checks
calvn added a commit that referenced this pull request Jul 2, 2020
* Add nil check for quota manager

* Add missing nil checks

Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@briankassouf briankassouf deleted the core/handle-nil-quota-mngr branch July 2, 2020 01:22
andaley pushed a commit that referenced this pull request Jul 17, 2020
* Add nil check for quota manager

* Add missing nil checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants