Add mount type to request earlier#9389
Merged
Merged
Conversation
…s even if the request fails authorization
alexanderbez
reviewed
Jul 6, 2020
| @@ -582,6 +582,8 @@ func (c *Core) handleRequest(ctx context.Context, req *logical.Request) (retResp | |||
| var nonHMACReqDataKeys []string | |||
| entry := c.router.MatchingMountEntry(ctx, req.Path) | |||
| if entry != nil { | |||
Contributor
There was a problem hiding this comment.
nit: I think formatting is off here.
alexanderbez
approved these changes
Jul 6, 2020
Collaborator
Author
No, the field was introduced in 1.5 in the first place. |
sgmiller
added a commit
that referenced
this pull request
Jul 6, 2020
…s even if the request fails authorization (#9389)
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
…s even if the request fails authorization (#9389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of requests with no vault token, routing never happens, where
MountType is typically populated on request. We have it from the
MatchingMountEntry check earlier in request handling, so this populates it
earlier, ensuring "mount_type" is on all audit entries.