Skip to content

Docs: Add Mittwald Vault Libraries#9402

Merged
austingebauer merged 1 commit into
hashicorp:masterfrom
ins0:patch-1
Jun 11, 2021
Merged

Docs: Add Mittwald Vault Libraries#9402
austingebauer merged 1 commit into
hashicorp:masterfrom
ins0:patch-1

Conversation

@ins0
Copy link
Copy Markdown
Contributor

@ins0 ins0 commented Jul 6, 2020

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Jul 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ins0 ins0 changed the title Add Mittwald Vault Libraries Docs: Add Mittwald Vault Libraries Jul 6, 2020
@ins0 ins0 changed the base branch from master to stable-website July 10, 2020 11:09
@ins0 ins0 changed the base branch from stable-website to master July 10, 2020 11:10
@ins0
Copy link
Copy Markdown
Contributor Author

ins0 commented Jul 10, 2020 •
edited
Loading

@austingebauer @kalafut is there anything i need to check or idk - not sure how to progress on this. Thanks! :)

@austingebauer
Copy link
Copy Markdown
Contributor

austingebauer commented Jul 20, 2020

Hi, @ins0. Thanks for opening up this PR! I'll be having a look and will get back to you on getting these added.

@ins0
Copy link
Copy Markdown
Contributor Author

ins0 commented Sep 18, 2020

Hey @austingebauer, thanks! Any news on this?

@ins0
Copy link
Copy Markdown
Contributor Author

ins0 commented Nov 13, 2020

@austingebauer any change u may have look now? ty!

@ins0 ins0 closed this Jun 10, 2021
@austingebauer
Copy link
Copy Markdown
Contributor

austingebauer commented Jun 10, 2021

Hi, @ins0. I apologize for the delayed response on this PR. I'm seeing that you've closed it now. Would you still like to have this merged? I've reviewed it with my team and can reopen/merge it now if that's the case. Again, thank you for the patience on this one! We appreciate the contribution.

@ins0
Copy link
Copy Markdown
Contributor Author

ins0 commented Jun 10, 2021

Thanks for the response. sure thing :) please reopen.

@austingebauer austingebauer reopened this Jun 10, 2021
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 10, 2021

@ins0 is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@austingebauer
Copy link
Copy Markdown
Contributor

austingebauer commented Jun 10, 2021

@ins0 - Great! We'll get this merged then. Are you able to resolve the conflict that's showing in website/pages/api-docs/libraries.mdx by chance?

@vercel vercel Bot temporarily deployed to Preview – vault-storybook June 11, 2021 07:19 Inactive
@ins0
Copy link
Copy Markdown
Contributor Author

ins0 commented Jun 11, 2021

@austingebauer done

@austingebauer austingebauer merged commit 77f9ff9 into hashicorp:master Jun 11, 2021
pull Bot pushed a commit to NOUIY/vault that referenced this pull request Sep 17, 2025
@hc-github-team-secure-vault-core @hellobontempo
feat: pre-fill SAML login role from URL (hashicorp#9394) (hashicorp#9402
cc9e227 
)

* prefill role for saml auth method

* add changelog

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@austingebauer austingebauer austingebauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ins0 @hashicorp-cla @austingebauer