Set PKI CA cert default for ttl#9405
Merged
Merged
Conversation
andaley
approved these changes
Jul 7, 2020
Contributor
andaley
left a comment
andaley
left a comment
There was a problem hiding this comment.
i always love a 1 line fix. thanks for handling this!
Monkeychip
added a commit
that referenced
this pull request
Jul 7, 2020
Monkeychip
added a commit
that referenced
this pull request
Jul 7, 2020
This was referenced Jul 13, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open api was missing the default ttl for when a user created a PKI ca certification. This PR fixes that.
Per the documentation, the default should be 30day (e.g. 720h).
Gif before:
Gif of with fix:
