Don't require AWS_ROLE_SESSION_NAME to sts:AssumeRoleWithWebIdentity#9416
Merged
Conversation
|
|
tvoran
approved these changes
Jul 14, 2020
Member
tvoran
left a comment
tvoran
left a comment
There was a problem hiding this comment.
This seems to work for me when I tested on EKS. Thanks for the patch!
Member
|
The test failures seem to be pre-existing on master, and pass locally. TestSealMigration_TransitToShamir_Post14 - sealmigration |
Merged
tvoran
added a commit
that referenced
this pull request
Jul 14, 2020
tvoran
added a commit
that referenced
this pull request
Jul 14, 2020
This was referenced Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9415