Skip to content

physical/gcs: use separate client for updating locks#9424

Merged
calvn merged 3 commits into
hashicorp:masterfrom
sethvargo:sethvargo/gcs_locks
Jul 9, 2020
Merged

physical/gcs: use separate client for updating locks#9424
calvn merged 3 commits into
hashicorp:masterfrom
sethvargo:sethvargo/gcs_locks

Conversation

@sethvargo
Copy link
Copy Markdown
Contributor

@sethvargo sethvargo commented Jul 8, 2020

Same rationale and design as #9423.

sethvargo
sethvargo commented Jul 8, 2020
View reviewed changes
Comment thread physical/gcs/gcs.go Outdated
Copy link
Copy Markdown
Contributor Author

@sethvargo sethvargo Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been deprecated for a very, very long time.

Copy link
Copy Markdown
Contributor

@calvn calvn Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalafut this might be fine to remove since we've had this notice for ~2yrs, but we should call this out in the changelog.

@sethvargo
Copy link
Copy Markdown
Contributor Author

sethvargo commented Jul 8, 2020

Tests:

$ GOOGLE_PROJECT_ID=vs-test-282716 go test -v -count=1 ./physical/gcs/...
=== RUN   TestHABackend
2020-07-08T13:01:21.487-0400 [DEBUG] configuring backend
2020-07-08T13:01:21.487-0400 [DEBUG] creating client
2020-07-08T13:01:21.487-0400 [DEBUG] configuration: bucket=vault-gcs-testacc-4692478361493701885 chunk_size=8388608 ha_enabled=true max_parallel=0
2020-07-08T13:01:21.487-0400 [DEBUG] creating client
2020-07-08T13:01:21.487-0400 [DEBUG] configuring backend
2020-07-08T13:01:21.487-0400 [DEBUG] creating client
2020-07-08T13:01:21.487-0400 [DEBUG] configuration: bucket=vault-gcs-testacc-4692478361493701885 chunk_size=8388608 ha_enabled=true max_parallel=0
2020-07-08T13:01:21.487-0400 [DEBUG] creating client
--- PASS: TestHABackend (24.18s)
=== RUN   TestBackend
2020-07-08T13:01:45.457-0400 [DEBUG] configuring backend
2020-07-08T13:01:45.457-0400 [DEBUG] configuration: bucket=vault-gcs-testacc-8657908517170831413 chunk_size=8388608 ha_enabled=false max_parallel=0
2020-07-08T13:01:45.457-0400 [DEBUG] creating client
--- PASS: TestBackend (11.70s)
PASS
ok  	github.com/hashicorp/vault/physical/gcs	36.121s

@kalafut kalafut requested a review from calvn July 9, 2020 00:27
calvn
calvn approved these changes Jul 9, 2020
View reviewed changes
Comment thread physical/gcs/gcs.go Outdated
Copy link
Copy Markdown
Contributor

@calvn calvn Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalafut this might be fine to remove since we've had this notice for ~2yrs, but we should call this out in the changelog.

Comment thread physical/gcs/gcs.go Outdated
@sethvargo
Copy link
Copy Markdown
Contributor Author

sethvargo commented Jul 9, 2020

@calvn updated - PTAL.

@calvn calvn merged commit 486ac45 into hashicorp:master Jul 9, 2020
calvn added a commit that referenced this pull request Jul 9, 2020
@sethvargo @calvn
physical/gcs: use separate client for updating locks (#9424)
8536229 
* physical/gcs: use separate client for updating locks

* Address review comments

Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>
calvn added a commit that referenced this pull request Jul 9, 2020
@calvn @sethvargo
physical/gcs: use separate client for updating locks (#9424) (#9439)
3bc551f 
* physical/gcs: use separate client for updating locks

* Address review comments

Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>

Co-authored-by: Seth Vargo <seth@sethvargo.com>
andaley pushed a commit that referenced this pull request Jul 17, 2020
@sethvargo @calvn @andaley
physical/gcs: use separate client for updating locks (#9424)
c76e1e3 
* physical/gcs: use separate client for updating locks

* Address review comments

Co-authored-by: Calvin Leung Huang <cleung2010@gmail.com>
@flaper87 flaper87 mentioned this pull request Oct 13, 2020
Closed
@sethvargo sethvargo deleted the sethvargo/gcs_locks branch November 17, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@calvn calvn calvn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sethvargo @calvn