Add docker dev build targets#9426
Conversation
raskchanky
left a comment
raskchanky
left a comment
There was a problem hiding this comment.
Everything here looks very similar to what I was digging through last week, trying to get a dev build into a Docker container. Thanks for adding this, and doing it in a much cleaner way than I did 😂
catsby
left a comment
catsby
left a comment
There was a problem hiding this comment.
Minor (but maybe not) nit: running this new step leaves the resulting binary in linux/amd64 format. build.sh will overwrite $GOPATH/bin/vault so If I run make docker-dev I have to run make dev to get a usable binary on my laptop. Should we customize or duplicate and trim build.sh to only compile this binary in linux/amd64 format in some temp directory, and then after successfully building the docker image then clean it up?
Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
|
@catsby I added the multi-stage build |
jasonodonnell
changed the title
catsby
left a comment
catsby
left a comment
There was a problem hiding this comment.
LGTM I tested both targets. It looks like the test test-race failure is unrelated
…icorp#9426) (hashicorp#9440) This reverts commit a55e884517a7c1f25e097a52e1555d4f81137068. Co-authored-by: Ryan Cragun <me@ryan.ec>
4 participants
This adds a slightly modified copy of the
docker-vaultDockerfile to the repo for building and testing dev Vault builds. This is helpful if you want to test development changes of Vault in Docker.